Headers: Adds optimized request headers #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
khdang,
sboshra,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel,
kirillg and
leminh98
as code owners
|
Do we have numbers around perf improvement ? |
|
From the description, I am not sure one is more optimized than the other. Can you please explain that also.. Some kind of summary. |
j82w
changed the title
Updated description with perf numbers. Roughly 7% increase in throughput. |
…re/azure-cosmos-dotnet-v3 into users/jawilley/direct/3.27.3
…re/azure-cosmos-dotnet-v3 into users/jawilley/direct/3.27.3
j82w
changed the title
Microsoft.Azure.Cosmos/src/Pagination/NetworkAttachedDocumentContainer.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/HeadersTests.cs
Show resolved
Hide resolved
kirankumarkolli
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Refactor the headers to use the new optimized header
Header structure:
Headers -> public contract (Ideally this should have been a public contract without implementation)
CosmosMessageHeadersInternal -> Internal contract the v3 SDK uses to workaround breaking changes since headers can not be modified. This is common headers used in both the request and response.
StoreRequestHeaders -> converts the RequestNameValueCollection to the CosmosMessageHeadersInternal
StoreResponseHeaders -> converts the StoreResponseNameValueCollection to the CosmosMessageHeadersInternal
HttpResponseHeadersWrapper -> gateway response implementation of CosmosMessageHeadersInternal
Performance results which shows roughly 7% increase in throughput:
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes ##2992